Linux: Relanding a patch from an external contributor.

Linux: Relanding a patch from an external contributor.

This patch was reverted because it leaked memory on every
window title set. This changes the patch around to use
UTF-8 XTextProperties and to free allocated memory
afterwards.

"""
After chromium stop using gtk+ for Linux/X11 all not ASCII
character in window title start looks like garbage. This
patch fixes this issue, by using algorithm similar to
gtk+/Qt's way of setting window titles.
"""

BUG=378096
First Review URL: https://codereview.chromium.org/414413002

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289529

[Elliot Glaysher, 2014-08-13 00:34:11]

sadrul: review

[Elliot Glaysher, 2014-08-13 00:34:12]

sadrul: review

[Elliot Glaysher, 2014-08-13 00:35:48]

sadrul: review
dushistov: fyi

(And sorry for the above incomplete mails; the "Reviewers" box does not respond
well to a combination of pressing enter and trying to reorder names.)

[sadrul, 2014-08-13 02:28:19]

https://codereview.chromium.org/464173002/diff/20001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right):

https://codereview.chromium.org/464173002/diff/20001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:639:
XCompoundTextStyle, &xtp);
Looks like XICCEncodingStyle can be = XUTF8StringStyle. Can we use that?

https://codereview.chromium.org/464173002/diff/20001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:642: const
std::string ascii_str = base::UTF16ToASCII(title);
The doc for UTF16ToASCII() states "The result must be known to be ASCII
beforehand". I don't think we can know that here?

[Elliot Glaysher, 2014-08-13 17:54:54]

ptal.

[sadrul, 2014-08-13 20:14:55]

Cool. LGTM

[Elliot Glaysher, 2014-08-13 20:19:44]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-08-13 20:21:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erg@chromium.org/464173002/40001

[commit-bot: I haz the power, 2014-08-13 21:56:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-13 22:26:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 22:26:18]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)

[Elliot Glaysher, 2014-08-13 22:37:05]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-08-13 22:41:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erg@chromium.org/464173002/40001

[commit-bot: I haz the power, 2014-08-14 12:09:14]

Committed patchset #3 (40001) as 289529