Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 414413002: After chromium stop using gtk+ for Linux/X11 all not ASCII character in window title start looks li… (Closed)

Created:
6 years, 5 months ago by dushistov
Modified:
6 years, 4 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

After chromium stop using gtk+ for Linux/X11 all not ASCII character in window title start looks like garbage. This patch fixes this issue, by using algorithm similar to gtk+/Qt's way of setting window titles. BUG=378096 R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286058

Patch Set 1 #

Patch Set 2 : remove superfluous reinterpret_cast #

Patch Set 3 : fix window title with X11/icewm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
dushistov
6 years, 5 months ago (2014-07-26 13:30:00 UTC) #1
Elliot Glaysher
This looks good, but I don't see your name in the AUTHORS file. Please: 1) ...
6 years, 4 months ago (2014-07-28 17:55:25 UTC) #2
dushistov
On 2014/07/28 17:55:25, Elliot Glaysher wrote: > This looks good, but I don't see your ...
6 years, 4 months ago (2014-07-28 19:04:33 UTC) #3
Elliot Glaysher
lgtm; I'll CQ this immediately. On 2014/07/28 19:04:33, dushistov wrote: > On 2014/07/28 17:55:25, Elliot ...
6 years, 4 months ago (2014-07-28 19:08:30 UTC) #4
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 4 months ago (2014-07-28 19:08:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dushistov@gmail.com/414413002/40001
6 years, 4 months ago (2014-07-28 20:36:04 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-29 00:07:32 UTC) #7
commit-bot: I haz the power
Change committed as 286058
6 years, 4 months ago (2014-07-29 02:52:38 UTC) #8
hashimoto
6 years, 4 months ago (2014-07-29 04:56:02 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/428823003/ by hashimoto@chromium.org.

The reason for reverting is: Speculative revert to fix
"_XTextListToTextProperty" leaking on Linux ASan LSan bots:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te...
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

Powered by Google App Engine
This is Rietveld 408576698