Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 464073: Have the utility process run out of process on Linux again by (Closed)

Created:
11 years ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Have the utility process run out of process on Linux again by using the /proc/self/exe trick we use for plugins. Since we don't need any resources from .pak files, this should be safe. BUG=22703 TEST=Install a theme, verify that it worked properly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34117

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -27 lines) Patch
M chrome/browser/extensions/extension_updater.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/utility_process_host.cc View 1 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
11 years ago (2009-12-08 23:45:02 UTC) #1
asargent_no_longer_on_chrome
Lgtm. Glad to see this.
11 years ago (2009-12-08 23:55:51 UTC) #2
tony
Updated from offline discussion with evan: 1) no longer add an #if for the /proc/self/exe ...
11 years ago (2009-12-09 00:22:54 UTC) #3
Evan Martin
11 years ago (2009-12-09 00:25:19 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698