Have the utility process run out of process on Linux again by

chrome/browser/utility_process_host.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/utility_process_host.h"
 
 #include "app/app_switches.h"
 #include "app/l10n_util.h"
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/render_messages.h"
 #include "ipc/ipc_switches.h"
 
 UtilityProcessHost::UtilityProcessHost(ResourceDispatcherHost* rdh,
                                        Client* client,
                                        ChromeThread::ID client_thread_id)
     : ChildProcessHost(UTILITY_PROCESS, rdh),
       client_(client),
       client_thread_id_(client_thread_id) {
@@ skipping 26 matching lines @@
 
   Send(new UtilityMsg_ParseUpdateManifest(xml));
   return true;
 }
 
 FilePath UtilityProcessHost::GetUtilityProcessCmd() {
   return GetChildPath();
 }
 
 bool UtilityProcessHost::StartProcess(const FilePath& exposed_dir) {
-#if defined(OS_LINUX)
-  // TODO(port): We should not reach here on Linux (crbug.com/22703).
-  // (crbug.com/23837) covers enabling this on Linux.
-  NOTREACHED();
-  return false;
-#endif
-
   // Name must be set or metrics_service will crash in any test which
   // launches a UtilityProcessHost.
   set_name(L"utility process");
 
   if (!CreateChannel())
     return false;
 
   FilePath exe_path = GetUtilityProcessCmd();
   if (exe_path.empty()) {
     NOTREACHED() << "Unable to get utility process binary name.";
     return false;
   }
 
   CommandLine* cmd_line = new CommandLine(exe_path);
   cmd_line->AppendSwitchWithValue(switches::kProcessType,
                                   switches::kUtilityProcess);
   cmd_line->AppendSwitchWithValue(switches::kProcessChannelID,
                                   ASCIIToWide(channel_id()));
-  // Pass on the browser locale.
+  // Pass on the browser locale.  TODO(tony): This touches the disk and
+  // checks for locale dlls/pak files.  It shouldn't need to.
   std::string locale = l10n_util::GetApplicationLocale(L"");
-  cmd_line->AppendSwitchWithValue(switches::kLang, ASCIIToWide(locale));
+  cmd_line->AppendSwitchWithValue(switches::kLang, locale);
 
   SetCrashReporterCommandLine(cmd_line);
 
   const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess();
   if (browser_command_line.HasSwitch(switches::kChromeFrame))
     cmd_line->AppendSwitch(switches::kChromeFrame);
 
 #if defined(OS_POSIX)
   // TODO(port): Sandbox this on Linux.  Also, zygote this to work with
   // Linux updating.
@@ skipping 43 matching lines @@
     IPC_MESSAGE_HANDLER(UtilityHostMsg_UnpackWebResource_Succeeded,
                         Client::OnUnpackWebResourceSucceeded)
     IPC_MESSAGE_HANDLER(UtilityHostMsg_UnpackWebResource_Failed,
                         Client::OnUnpackWebResourceFailed)
     IPC_MESSAGE_HANDLER(UtilityHostMsg_ParseUpdateManifest_Succeeded,
                         Client::OnParseUpdateManifestSucceeded)
     IPC_MESSAGE_HANDLER(UtilityHostMsg_ParseUpdateManifest_Failed,
                         Client::OnParseUpdateManifestFailed)
   IPC_END_MESSAGE_MAP_EX()
 }