Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 464039: enabled one browser test and tag JavascriptAlertActivatesTab, ReloadThenCance... (Closed)

Created:
11 years ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

enabled one browser test and tag JavascriptAlertActivatesTab, ReloadThenCancelBeforeUnload, & SingleBeforeUnloadAfterWindowClose as disabled so they compile but don't run on the Mac TEST=tree stays green BUG=29424 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M chrome/browser/browser_browsertest.cc View 5 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
TVL
11 years ago (2009-12-04 18:08:26 UTC) #1
Mark Mentovai
11 years ago (2009-12-04 18:09:24 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698