Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3130)

Unified Diff: chrome/browser/browser_browsertest.cc

Issue 464039: enabled one browser test and tag JavascriptAlertActivatesTab, ReloadThenCance... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_browsertest.cc
===================================================================
--- chrome/browser/browser_browsertest.cc (revision 33822)
+++ chrome/browser/browser_browsertest.cc (working copy)
@@ -104,8 +104,11 @@
EXPECT_EQ(WideToUTF16(test_title), tab_title);
}
-#if !defined(OS_MACOSX)
-// TODO(port): BUG16322
+#if defined(OS_MACOSX)
+// http://crbug.com//29424
+#define JavascriptAlertActivatesTab DISABLED_JavascriptAlertActivatesTab
+#endif
+
IN_PROC_BROWSER_TEST_F(BrowserTest, JavascriptAlertActivatesTab) {
GURL url(ui_test_utils::GetTestUrl(L".", L"title1.html"));
ui_test_utils::NavigateToURL(browser(), url);
@@ -122,7 +125,6 @@
EXPECT_EQ(2, browser()->tab_count());
EXPECT_EQ(1, browser()->selected_index());
}
-#endif // !defined(OS_MACOSX)
// Create 34 tabs and verify that a lot of processes have been created. The
// exact number of processes depends on the amount of memory. Previously we
@@ -147,13 +149,14 @@
}
}
+#if defined(OS_MACOSX)
+// http://crbug.com//29424
+#define ReloadThenCancelBeforeUnload DISABLED_ReloadThenCancelBeforeUnload
+#endif
+
// Test for crbug.com/22004. Reloading a page with a before unload handler and
// then canceling the dialog should not leave the throbber spinning.
-#if defined(OS_MACOSX)
-IN_PROC_BROWSER_TEST_F(BrowserTest, DISABLED_ReloadThenCancelBeforeUnload) {
-#else
IN_PROC_BROWSER_TEST_F(BrowserTest, ReloadThenCancelBeforeUnload) {
-#endif
GURL url("data:text/html," + BEFORE_UNLOAD_HTML);
ui_test_utils::NavigateToURL(browser(), url);
@@ -169,14 +172,16 @@
ExecuteJavascriptInWebFrame(L"", L"onbeforeunload=null;");
}
-// Test for crbug.com/11647. A page closed with window.close() should not have
-// two beforeunload dialogs shown.
#if defined(OS_MACOSX)
-IN_PROC_BROWSER_TEST_F(BrowserTest,
- DISABLED_SingleBeforeUnloadAfterWindowClose) {
+// http://crbug.com//29424
+#define MAYBE_SingleBeforeUnloadAfterWindowClose DISABLED_SingleBeforeUnloadAfterWindowClose
#else
-IN_PROC_BROWSER_TEST_F(BrowserTest, FLAKY_SingleBeforeUnloadAfterWindowClose) {
+#define MAYBE_SingleBeforeUnloadAfterWindowClose FLAKY_SingleBeforeUnloadAfterWindowClose
#endif
+
+// Test for crbug.com/11647. A page closed with window.close() should not have
+// two beforeunload dialogs shown.
+IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_SingleBeforeUnloadAfterWindowClose) {
browser()->GetSelectedTabContents()->render_view_host()->
ExecuteJavascriptInWebFrame(L"", OPEN_NEW_BEFOREUNLOAD_PAGE);
@@ -210,12 +215,7 @@
// Test IDC_CREATE_SHORTCUTS command is enabled for url scheme file, ftp, http
// and https and disabled for chrome://, about:// etc.
-#if defined(OS_MACOSX)
-IN_PROC_BROWSER_TEST_F(BrowserTest,
- DISABLED_CommandCreateAppShortcut) {
-#else
IN_PROC_BROWSER_TEST_F(BrowserTest, CommandCreateAppShortcut) {
-#endif
static const wchar_t kDocRoot[] = L"chrome/test/data";
CommandUpdater* command_updater = browser()->command_updater();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698