Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 463983002: Ensure that the allow on all urls checkbox shows up in chrome:extensions (Closed)

Created:
6 years, 4 months ago by Devlin
Modified:
6 years, 4 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Ensure that the allow on all urls checkbox shows up in chrome:extensions Previously, if you allowed an extension on all urls, the checkbox disappeared, which was obviously very bad. Fix it. BUG=402958 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289336

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Devlin
6 years, 4 months ago (2014-08-12 18:06:50 UTC) #1
not at google - send to devlin
lgtm
6 years, 4 months ago (2014-08-12 18:11:30 UTC) #2
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-12 18:12:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/463983002/1
6 years, 4 months ago (2014-08-12 18:13:45 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-13 00:55:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 03:55:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/6190)
6 years, 4 months ago (2014-08-13 03:55:14 UTC) #7
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-13 15:22:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/463983002/1
6 years, 4 months ago (2014-08-13 15:23:08 UTC) #9
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 4 months ago (2014-08-13 17:37:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/463983002/1
6 years, 4 months ago (2014-08-13 17:38:33 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 18:58:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 289336

Powered by Google App Engine
This is Rietveld 408576698