Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 463983002: Ensure that the allow on all urls checkbox shows up in chrome:extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index e8c5110ce1d4c78a4a7f1e1aa0129c686ef1ff3e..e436bb9181d65aa1ec1d75df7b758121040ae0fc 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -286,7 +286,9 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
// - The extension has access to enough urls that we can't just let it run
// on those specified in the permissions.
bool wants_all_urls =
- extension->permissions_data()->HasWithheldImpliedAllHosts();
+ extension->permissions_data()->HasWithheldImpliedAllHosts() ||
+ util::AllowedScriptingOnAllUrls(extension->id(),
+ extension_service_->GetBrowserContext());
extension_data->SetBoolean("wantsAllUrls", wants_all_urls);
extension_data->SetBoolean(
"allowAllUrls",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698