Issue 463853002: Power profiler should check for the capability CanProfilePower

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463853002: Power profiler should check for the capability CanProfilePower (Closed)

Created:
6 years, 4 months ago by vivekg_samsung

Modified:
6 years, 4 months ago

Reviewers:
vivekg, apavlov, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Power profiler should check for the capability CanProfilePower The patch [1] removed the global capabilities set. The power profiler depends on whether there exists a power service and it has a valid data provider. If these are met, only then the devtools can do power profiling. The checkbox "Power" should only be visible if the capability exists. Restoring the required checks. [1] https://codereview.chromium.org/388963004 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180058

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelinePanel.js	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/463853002/1

6 years, 4 months ago (2014-08-12 09:01:32 UTC) #4

Message was sent while issue was closed.

Change committed as 180058

Expand Messages | Collapse Messages