Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 388963004: DevTools: get rid of the global capabilities set. (Closed)

Created:
6 years, 5 months ago by pfeldman
Modified:
6 years, 5 months ago
Reviewers:
dgozman, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: get rid of the global capabilities set. NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178145

Patch Set 1 : #

Total comments: 2

Patch Set 2 : For landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -37 lines) Patch
M Source/devtools/front_end/common/Settings.js View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/devtools/front_end/console/ConsolePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/host/Platform.js View 1 chunk +9 lines, -1 line 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 5 chunks +31 lines, -20 lines 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePowerOverview.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
pfeldman
6 years, 5 months ago (2014-07-14 16:15:06 UTC) #1
sergeyv
lgtm
6 years, 5 months ago (2014-07-14 16:22:03 UTC) #2
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-14 16:23:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/388963004/20001
6 years, 5 months ago (2014-07-14 16:23:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-14 17:20:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 17:21:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/12385)
6 years, 5 months ago (2014-07-14 17:21:18 UTC) #7
dgozman
https://codereview.chromium.org/388963004/diff/20001/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/388963004/diff/20001/Source/devtools/front_end/sdk/Target.js#newcode28 Source/devtools/front_end/sdk/Target.js:28: this._capabilities = {}; I'd move this before initializeCapability calls ...
6 years, 5 months ago (2014-07-14 20:47:12 UTC) #8
pfeldman
https://codereview.chromium.org/388963004/diff/20001/Source/devtools/front_end/sdk/Target.js File Source/devtools/front_end/sdk/Target.js (right): https://codereview.chromium.org/388963004/diff/20001/Source/devtools/front_end/sdk/Target.js#newcode28 Source/devtools/front_end/sdk/Target.js:28: this._capabilities = {}; On 2014/07/14 20:47:11, dgozman wrote: > ...
6 years, 5 months ago (2014-07-15 04:53:13 UTC) #9
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-15 04:53:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/388963004/40001
6 years, 5 months ago (2014-07-15 04:53:42 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-15 05:54:42 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-15 06:30:22 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16941)
6 years, 5 months ago (2014-07-15 06:30:23 UTC) #14
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-15 06:43:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/388963004/40001
6 years, 5 months ago (2014-07-15 06:43:55 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 06:45:13 UTC) #17
Message was sent while issue was closed.
Change committed as 178145

Powered by Google App Engine
This is Rietveld 408576698