Issue 463593003: More SkTileGrid refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463593003: More SkTileGrid refactoring. (Closed)

Created:
6 years, 4 months ago by mtklein_C

Modified:
6 years, 4 months ago

Reviewers:
mtklein, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More SkTileGrid refactoring. I've rearranged the code a bit more and added more notes. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a7f7b168ae6c4658efe2a7acd1b22f2dd989bb35

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -87 lines)			Patch
	M	src/core/SkTileGrid.h	View		2 chunks	+5 lines, -18 lines	0 comments	Download
	M	src/core/SkTileGrid.cpp	View	1 2	1 chunk	+78 lines, -69 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/463593003/40001

6 years, 4 months ago (2014-08-11 18:50:38 UTC) #3

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

6 years, 4 months ago (2014-08-11 18:50:39 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-11 19:06:03 UTC) #6

Message was sent while issue was closed.

Change committed as a7f7b168ae6c4658efe2a7acd1b22f2dd989bb35