Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: Source/core/events/DOMWindowEventQueue.cpp

Issue 463543002: Oilpan: Ensure that classes with virtual trace methods always have vtables for their left-most base… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/events/DOMWindowEventQueue.cpp
diff --git a/Source/core/events/DOMWindowEventQueue.cpp b/Source/core/events/DOMWindowEventQueue.cpp
index b4705379ac5fbe5fe410add3f0ef89cb9d80bc50..9475f2dbed70bc8935402a4fbee74e5dfce21c2a 100644
--- a/Source/core/events/DOMWindowEventQueue.cpp
+++ b/Source/core/events/DOMWindowEventQueue.cpp
@@ -40,7 +40,11 @@ public:
DOMWindowEventQueueTimer(DOMWindowEventQueue* eventQueue, ExecutionContext* context)
: SuspendableTimer(context)
, m_eventQueue(eventQueue) { }
- void trace(Visitor* visitor) { visitor->trace(m_eventQueue); }
+ virtual void trace(Visitor* visitor)
Mads Ager (chromium) 2014/08/12 06:07:04 Separate the constructor and the trace method with
+ {
+ visitor->trace(m_eventQueue);
+ SuspendableTimer::trace(visitor);
+ }
private:
virtual void fired() { m_eventQueue->pendingEventTimerFired(); }

Powered by Google App Engine
This is Rietveld 408576698