Oilpan: Ensure that classes with virtual trace methods always have vtables for their left-most base…

Source/core/events/DOMWindowEventQueue.cpp

 /*
  * Copyright (C) 2010 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 22 matching lines @@
 #include "core/inspector/InspectorInstrumentation.h"
 
 namespace blink {
 
 class DOMWindowEventQueueTimer : public NoBaseWillBeGarbageCollectedFinalized<DOMWindowEventQueueTimer>, public SuspendableTimer {
     WTF_MAKE_NONCOPYABLE(DOMWindowEventQueueTimer);
 public:
     DOMWindowEventQueueTimer(DOMWindowEventQueue* eventQueue, ExecutionContext* context)
         : SuspendableTimer(context)
         , m_eventQueue(eventQueue) { }
-    void trace(Visitor* visitor) { visitor->trace(m_eventQueue); }
+    virtual void trace(Visitor* visitor)

[Mads Ager (chromium), 2014/08/12 06:07:04]

Separate the constructor and the trace method with a blank line?

+    {
+        visitor->trace(m_eventQueue);
+        SuspendableTimer::trace(visitor);
+    }
 
 private:
     virtual void fired() { m_eventQueue->pendingEventTimerFired(); }
 
     RawPtrWillBeMember<DOMWindowEventQueue> m_eventQueue;
 };
 
 PassRefPtrWillBeRawPtr<DOMWindowEventQueue> DOMWindowEventQueue::create(ExecutionContext* context)
 {
     return adoptRefWillBeNoop(new DOMWindowEventQueue(context));
@@ skipping 90 matching lines @@
 void DOMWindowEventQueue::dispatchEvent(PassRefPtrWillBeRawPtr<Event> event)
 {
     EventTarget* eventTarget = event->target();
     if (eventTarget->toDOMWindow())
         eventTarget->toDOMWindow()->dispatchEvent(event, nullptr);
     else
         eventTarget->dispatchEvent(event);
 }
 
 }