Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: Source/core/page/Page.cpp

Issue 46353003: Switch AutoscrollController to use animation system instead of timer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@gclient
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Page.cpp
diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp
index b3de6eb0274e811f65fe97b5d4eb7e4a2c18f94c..0f221e5a0733f8977b8d21721de291f3eec1295c 100644
--- a/Source/core/page/Page.cpp
+++ b/Source/core/page/Page.cpp
@@ -96,7 +96,7 @@ float deviceScaleFactor(Frame* frame)
}
Page::Page(PageClients& pageClients)
- : m_autoscrollController(AutoscrollController::create())
+ : m_autoscrollController(AutoscrollController::create(this))
eseidel 2013/11/01 19:43:23 I wonder why this isn't lazily created. I guess i
, m_chrome(Chrome::create(this, pageClients.chromeClient))
, m_dragCaretController(DragCaretController::create())
, m_dragController(DragController::create(this, pageClients.dragClient))
@@ -165,60 +165,6 @@ ViewportDescription Page::viewportDescription() const
return mainFrame() && mainFrame()->document() ? mainFrame()->document()->viewportDescription() : ViewportDescription();
}
-bool Page::autoscrollInProgress() const
-{
- return m_autoscrollController->autoscrollInProgress();
-}
-
-bool Page::autoscrollInProgress(const RenderBox* renderer) const
-{
- return m_autoscrollController->autoscrollInProgress(renderer);
-}
-
-bool Page::panScrollInProgress() const
-{
- return m_autoscrollController->panScrollInProgress();
-}
-
-void Page::startAutoscrollForSelection(RenderObject* renderer)
-{
- return m_autoscrollController->startAutoscrollForSelection(renderer);
-}
-
-void Page::stopAutoscrollIfNeeded(RenderObject* renderer)
-{
- m_autoscrollController->stopAutoscrollIfNeeded(renderer);
-}
-
-
-void Page::stopAutoscrollTimer()
-{
- m_autoscrollController->stopAutoscrollTimer();
-}
-
-void Page::updateAutoscrollRenderer()
-{
- m_autoscrollController->updateAutoscrollRenderer();
-}
-
-void Page::updateDragAndDrop(Node* dropTargetNode, const IntPoint& eventPosition, double eventTime)
-{
- m_autoscrollController->updateDragAndDrop(dropTargetNode, eventPosition, eventTime);
-}
-
-#if OS(WIN)
-void Page::handleMouseReleaseForPanScrolling(Frame* frame, const PlatformMouseEvent& point)
-{
- m_autoscrollController->handleMouseReleaseForPanScrolling(frame, point);
-}
-
-void Page::startPanScrolling(RenderBox* renderer, const IntPoint& point)
-{
- m_autoscrollController->startPanScrolling(renderer, point);
-}
-#endif
-
-
ScrollingCoordinator* Page::scrollingCoordinator()
{
if (!m_scrollingCoordinator && m_settings->scrollingCoordinatorEnabled())

Powered by Google App Engine
This is Rietveld 408576698