Switch AutoscrollController to use animation system instead of timer

Switch AutoscrollController to use animation system instead of timer

This switches the AutoscrollController from using a 50ms timer to using
our animation system to do pan scrolling. The 50ms timer capped us at a janky
20FPS at best whereas our animation system can easily hit 60FPS in most cases.
This also cleans up the controller logic a bit to thin down the Page interface.

BUG=310791
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161201

[esprehn, 2013-11-01 19:37:36]

couple nits, lgtm

https://codereview.chromium.org/46353003/diff/1/Source/core/page/AutoscrollCo...
File Source/core/page/AutoscrollController.h (right):

https://codereview.chromium.org/46353003/diff/1/Source/core/page/AutoscrollCo...
Source/core/page/AutoscrollController.h:56: static
PassOwnPtr<AutoscrollController> create(Page*);
This should probably be a reference.

https://codereview.chromium.org/46353003/diff/1/Source/core/page/AutoscrollCo...
Source/core/page/AutoscrollController.h:73: explicit
AutoscrollController(Page*);
This should probably be a reference.

https://codereview.chromium.org/46353003/diff/1/Source/core/page/EventHandler...
File Source/core/page/EventHandler.cpp (right):

https://codereview.chromium.org/46353003/diff/1/Source/core/page/EventHandler...
Source/core/page/EventHandler.cpp:872: return &page->autoscrollController();
We usually write:

if (Page* page = m_frame->page())
  return &page->autoscrollController();
return 0;

[eseidel, 2013-11-01 19:42:11]

You're blowing my mind.

Note: most everything in the page/ directory plans to move to the other side of
the embedding layer (and eventually up into the browser/) as part of out of
process iframes (OOPI).

[eseidel, 2013-11-01 19:43:23]

lgtm

https://codereview.chromium.org/46353003/diff/1/Source/core/page/Page.cpp
File Source/core/page/Page.cpp (right):

https://codereview.chromium.org/46353003/diff/1/Source/core/page/Page.cpp#new...
Source/core/page/Page.cpp:99: :
m_autoscrollController(AutoscrollController::create(this))
I wonder why this isn't lazily created.  I guess it just doesn't matter.

[jamesr, 2013-11-01 19:46:43]

On 2013/11/01 19:42:11, eseidel wrote:
> Note: most everything in the page/ directory plans to move to the other side
of
> the embedding layer (and eventually up into the browser/) as part of out of
> process iframes (OOPI).

Yup.  By splitting the autoscroll controller calls out of Page I'm hopefully
making this process easier.

[commit-bot: I haz the power, 2013-11-01 19:49:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/46353003/120001

[commit-bot: I haz the power, 2013-11-01 21:25:07]

Change committed as 161201