Chromium Code Reviews
Help | Chromium Project | Sign in
(222)

Issue 46353003: Switch AutoscrollController to use animation system instead of timer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by jamesr
Modified:
3 years, 4 months ago
Reviewers:
esprehn, eseidel
CC:
blink-reviews, zoltan1, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, Nate Chapin, dstockwell, dcheng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@gclient
Visibility:
Public.

Description

Switch AutoscrollController to use animation system instead of timer This switches the AutoscrollController from using a 50ms timer to using our animation system to do pan scrolling. The 50ms timer capped us at a janky 20FPS at best whereas our animation system can easily hit 60FPS in most cases. This also cleans up the controller logic a bit to thin down the Page interface. BUG=310791 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161201

Patch Set 1 #

Total comments: 4

Patch Set 2 : addresses review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -133 lines) Patch
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/AutoscrollController.h View 1 4 chunks +11 lines, -8 lines 0 comments Download
M Source/core/page/AutoscrollController.cpp View 1 15 chunks +27 lines, -26 lines 0 comments Download
M Source/core/page/EventHandler.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 10 chunks +27 lines, -22 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.h View 2 chunks +1 line, -13 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 chunks +1 line, -55 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 5 chunks +5 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 7 (0 generated)
jamesr
3 years, 4 months ago (2013-11-01 18:30:26 UTC) #1
esprehn
couple nits, lgtm https://codereview.chromium.org/46353003/diff/1/Source/core/page/AutoscrollController.h File Source/core/page/AutoscrollController.h (right): https://codereview.chromium.org/46353003/diff/1/Source/core/page/AutoscrollController.h#newcode56 Source/core/page/AutoscrollController.h:56: static PassOwnPtr<AutoscrollController> create(Page*); This should probably ...
3 years, 4 months ago (2013-11-01 19:37:36 UTC) #2
eseidel
You're blowing my mind. Note: most everything in the page/ directory plans to move to ...
3 years, 4 months ago (2013-11-01 19:42:11 UTC) #3
eseidel
lgtm https://codereview.chromium.org/46353003/diff/1/Source/core/page/Page.cpp File Source/core/page/Page.cpp (right): https://codereview.chromium.org/46353003/diff/1/Source/core/page/Page.cpp#newcode99 Source/core/page/Page.cpp:99: : m_autoscrollController(AutoscrollController::create(this)) I wonder why this isn't lazily ...
3 years, 4 months ago (2013-11-01 19:43:23 UTC) #4
jamesr
On 2013/11/01 19:42:11, eseidel wrote: > Note: most everything in the page/ directory plans to ...
3 years, 4 months ago (2013-11-01 19:46:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/46353003/120001
3 years, 4 months ago (2013-11-01 19:49:02 UTC) #6
commit-bot: I haz the power
3 years, 4 months ago (2013-11-01 21:25:07 UTC) #7
Message was sent while issue was closed.
Change committed as 161201
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62