Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2167)

Unified Diff: chrome/browser/notifications/desktop_notifications_unittest.h

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/desktop_notifications_unittest.h
===================================================================
--- chrome/browser/notifications/desktop_notifications_unittest.h (revision 66634)
+++ chrome/browser/notifications/desktop_notifications_unittest.h (working copy)
@@ -22,15 +22,14 @@
#include "testing/gtest/include/gtest/gtest.h"
class DesktopNotificationsTest;
-typedef LoggingNotificationProxyBase<DesktopNotificationsTest>
+typedef LoggingNotificationDelegate<DesktopNotificationsTest>
LoggingNotificationProxy;
// Test version of the balloon collection which counts the number
// of notifications that are added to it.
class MockBalloonCollection : public BalloonCollectionImpl {
public:
- MockBalloonCollection() :
- log_proxy_(new LoggingNotificationProxy()) {}
+ MockBalloonCollection() {}
// Our mock collection has an area large enough for a fixed number
// of balloons.
@@ -40,7 +39,6 @@
// BalloonCollectionImpl overrides
virtual void Add(const Notification& notification,
Profile* profile);
- virtual bool Remove(const Notification& notification);
virtual bool HasSpace() const { return count() < kMockBalloonSpace; }
virtual Balloon* MakeBalloon(const Notification& notification,
Profile* profile);
@@ -63,7 +61,6 @@
private:
std::deque<Balloon*> balloons_;
- scoped_refptr<LoggingNotificationProxy> log_proxy_;
};
class DesktopNotificationsTest : public testing::Test {

Powered by Google App Engine
This is Rietveld 408576698