Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1620)

Unified Diff: chrome/browser/notifications/desktop_notifications_unittest.cc

Issue 4635007: When an extension is uninstalled, close all desktop notifications from that e... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/desktop_notifications_unittest.cc
===================================================================
--- chrome/browser/notifications/desktop_notifications_unittest.cc (revision 66634)
+++ chrome/browser/notifications/desktop_notifications_unittest.cc (working copy)
@@ -16,26 +16,18 @@
void MockBalloonCollection::Add(const Notification& notification,
Profile* profile) {
- // Swap in the logging proxy for the purpose of logging calls that
+ // Swap in a logging proxy for the purpose of logging calls that
// would be made into javascript, then pass this down to the
// balloon collection.
- Notification test_notification(notification.origin_url(),
- notification.content_url(),
- notification.display_source(),
- string16(), /* replace_id */
- log_proxy_.get());
+ Notification test_notification(
+ notification.origin_url(),
+ notification.content_url(),
+ notification.display_source(),
+ notification.replace_id(),
+ new LoggingNotificationProxy(notification.notification_id()));
BalloonCollectionImpl::Add(test_notification, profile);
}
-bool MockBalloonCollection::Remove(const Notification& notification) {
- Notification test_notification(notification.origin_url(),
- notification.content_url(),
- notification.display_source(),
- string16(), /* replace_id */
- log_proxy_.get());
- return BalloonCollectionImpl::Remove(test_notification);
-}
-
Balloon* MockBalloonCollection::MakeBalloon(const Notification& notification,
Profile* profile) {
// Start with a normal balloon but mock out the view.
« no previous file with comments | « chrome/browser/notifications/desktop_notifications_unittest.h ('k') | chrome/browser/notifications/notification.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698