Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/tools/gn/input_conversion.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/gyp_helper.cc ('k') | trunk/src/tools/gn/item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/input_conversion.cc
===================================================================
--- trunk/src/tools/gn/input_conversion.cc (revision 232660)
+++ trunk/src/tools/gn/input_conversion.cc (working copy)
@@ -117,7 +117,9 @@
}
BuildSettings build_settings;
- Settings settings(&build_settings, std::string());
+ Label empty_label;
+ Toolchain toolchain(empty_label);
+ Settings settings(&build_settings, &toolchain, std::string());
Scope scope(&settings);
Err nested_err;
« no previous file with comments | « trunk/src/tools/gn/gyp_helper.cc ('k') | trunk/src/tools/gn/item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698