Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Unified Diff: trunk/src/tools/gn/gyp_helper.cc

Issue 46313006: Revert 232657 "GN: toolchain threading cleanup" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/functions.cc ('k') | trunk/src/tools/gn/input_conversion.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/gyp_helper.cc
===================================================================
--- trunk/src/tools/gn/gyp_helper.cc (revision 232660)
+++ trunk/src/tools/gn/gyp_helper.cc (working copy)
@@ -45,10 +45,10 @@
}
std::string GypHelper::GetNameForTarget(const Target* target) const {
- if (target->settings()->is_default())
+ const Toolchain* toolchain = target->settings()->toolchain();
+ if (toolchain->is_default())
return target->label().name(); // Default toolchain has no suffix.
- return target->label().name() + "_" +
- target->settings()->toolchain_label().name();
+ return target->label().name() + "_" + toolchain->label().name();
}
std::string GypHelper::GetFullRefForTarget(const Target* target) const {
« no previous file with comments | « trunk/src/tools/gn/functions.cc ('k') | trunk/src/tools/gn/input_conversion.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698