Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/functions.cc

Issue 46313003: Implement target visibility in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/command_gen.cc ('K') | « tools/gn/function_toolchain.cc ('k') | tools/gn/gn.gyp » ('j') | tools/gn/visibility.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions.cc
diff --git a/tools/gn/functions.cc b/tools/gn/functions.cc
index 43cdcd36cf4f5ea6f09d393fed312300f4a21fe0..f85b57cd8382983494ef7200bef0f2be7f40504e 100644
--- a/tools/gn/functions.cc
+++ b/tools/gn/functions.cc
@@ -229,6 +229,8 @@ Value RunConfig(const FunctionCallNode* function,
// Create the new config.
scoped_ptr<Config> config(new Config(scope->settings(), label));
config->set_defined_from(function);
+ if (!Visibility::FillItemVisibility(config.get(), scope, err))
+ return Value();
// Fill it.
const SourceDir& input_dir = scope->GetSourceDir();
« tools/gn/command_gen.cc ('K') | « tools/gn/function_toolchain.cc ('k') | tools/gn/gn.gyp » ('j') | tools/gn/visibility.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698