Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/function_toolchain.cc

Issue 46313003: Implement target visibility in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/command_gen.cc ('K') | « tools/gn/command_gen.cc ('k') | tools/gn/functions.cc » ('j') | tools/gn/visibility.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/function_toolchain.cc
diff --git a/tools/gn/function_toolchain.cc b/tools/gn/function_toolchain.cc
index 3d1a6552319d9d14acaf483625454b9c3e1c33fa..dc5c8d26c7e1fdc77325ecec61da7877abaf3df4 100644
--- a/tools/gn/function_toolchain.cc
+++ b/tools/gn/function_toolchain.cc
@@ -105,6 +105,7 @@ Value RunToolchain(Scope* scope,
// manager, but that has to be done in the lock.
scoped_ptr<Toolchain> toolchain(new Toolchain(scope->settings(), label));
toolchain->set_defined_from(function);
+ toolchain->visibility().SetPublic();
Scope block_scope(scope);
block_scope.SetProperty(&kToolchainPropertyKey, toolchain.get());
« tools/gn/command_gen.cc ('K') | « tools/gn/command_gen.cc ('k') | tools/gn/functions.cc » ('j') | tools/gn/visibility.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698