Issue 463042: Fixes bug where we wouldn't force a maximized window on Chrome OS...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463042: Fixes bug where we wouldn't force a maximized window on Chrome OS... (Closed)

Created:
11 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes bug where we wouldn't force a maximized window on Chrome OS during login. This happens because on Chrome OS we start the WM and Chrome at the same time, which means it's possiblef for us not to be able to get the name of the window manager. I've changed the code to assume that if we can't get the name of the window manager we're on Chrome OS. This isn't perfect. Hopefully once the WM tells us we're maximized before we're shown we can do away with this code. BUG=ChromeOS bug 929 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33985

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/browser_extenders.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2009/12/07 19:13:36, sky wrote:
>

Expand Messages | Collapse Messages