Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: chrome/browser/chromeos/browser_extenders.cc

Issue 463042: Fixes bug where we wouldn't force a maximized window on Chrome OS... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/browser_extenders.cc
===================================================================
--- chrome/browser/chromeos/browser_extenders.cc (revision 33966)
+++ chrome/browser/chromeos/browser_extenders.cc (working copy)
@@ -92,8 +92,12 @@
if (browser->type() == Browser::TYPE_NORMAL) {
std::string wm_name;
- force_maximized_window_ = x11_util::GetWindowManagerName(&wm_name) &&
- wm_name == kChromeOsWindowManagerName;
+ bool wm_name_valid = x11_util::GetWindowManagerName(&wm_name);
+ // NOTE: On Chrome OS the wm and Chrome are started in parallel. This
+ // means it's possible for us not to be able to get the name of the window
+ // manager. We assume that when this happens we're on Chrome OS.
+ force_maximized_window_ = (!wm_name_valid ||
+ wm_name == kChromeOsWindowManagerName);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698