Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 462993003: Set maximum output size for scaled-image-cache images (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@m37_2062
Visibility:
Public.

Description

Set maximum output size for scaled-image-cache images Accessable via: SkGraphics::{G|S}etImageCacheSingleAllocationByteLimit() Also, a unit test. BUG=389439 R=reed@google.com, humper@google.com, reveman@chromium.org, tomhudson@google.com, vangelis@chromium.org Author: halcanary@google.com Review URL: https://codereview.chromium.org/394003003 Committed: https://skia.googlesource.com/skia/+/0d78ac2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -45 lines) Patch
M bench/ImageCacheBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkGraphics.h View 1 chunk +41 lines, -3 lines 0 comments Download
M src/core/SkBitmapProcState.cpp View 2 chunks +17 lines, -2 lines 0 comments Download
M src/core/SkScaledImageCache.h View 5 chunks +23 lines, -12 lines 0 comments Download
M src/core/SkScaledImageCache.cpp View 10 chunks +56 lines, -26 lines 0 comments Download
M tests/ImageCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A tests/ScaledImageCache.cpp View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
6 years, 4 months ago (2014-08-12 19:20:48 UTC) #1
reed1
lgtm
6 years, 4 months ago (2014-08-12 19:22:21 UTC) #2
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-12 19:22:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/462993003/1
6 years, 4 months ago (2014-08-12 19:23:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 19:23:37 UTC) #5
commit-bot: I haz the power
Failed to apply patch for bench/ImageCacheBench.cpp: While running git apply --index -p1; error: patch failed: ...
6 years, 4 months ago (2014-08-12 19:23:41 UTC) #6
hal.canary
6 years, 4 months ago (2014-08-12 19:28:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as 0d78ac2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698