Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 462983003: [WIP] Implement BackGroundFilter as seperate layer in cc (Closed)

Created:
6 years, 4 months ago by sivag
Modified:
5 years, 9 months ago
Reviewers:
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Currently background filters just allow you to apply a FilterOperation to some content in a frame by doing a copy into a texture and applying the FilterOperations there. But there are many things than cc layers can do (eg. clipping/transforms) that FilterOperations couldn't. So now people keep having to write new shaders in Skia and new FilterOperations to do these types of things such as zooming. If instead a background filter was a Layer type that simply copies whatever is already in its target at some bounding box (doesn't need to be its own position/size), and then produces that copied stuff as its own output again wherever it is positioned. Then it could just use foreground filters to apply effects, as well as transform etc. BUG=392214

Patch Set 1 #

Patch Set 2 : Implementing stubs #

Patch Set 3 : Rebasing TOT #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+376 lines, -0 lines) Patch
M cc/cc.gyp View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
A cc/layers/background_filter_layer.h View 1 1 chunk +45 lines, -0 lines 0 comments Download
A cc/layers/background_filter_layer.cc View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
A cc/layers/background_filter_layer_impl.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
A cc/layers/background_filter_layer_impl.cc View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M cc/output/software_renderer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/output/software_renderer.cc View 3 chunks +7 lines, -0 lines 0 comments Download
M cc/quads/draw_quad.h View 1 chunk +1 line, -0 lines 0 comments Download
A cc/quads/filter_draw_quad.h View 1 2 3 1 chunk +49 lines, -0 lines 0 comments Download
A cc/quads/filter_draw_quad.cc View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
M cc/quads/render_pass.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/cc_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/common/cc_messages.cc View 1 2 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
Sikugu_
5 years, 9 months ago (2015-03-05 13:00:10 UTC) #1
Message was sent while issue was closed.
sivagunturi@chromium.org changed reviewers:
- danakj@chromium.org

Powered by Google App Engine
This is Rietveld 408576698