Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 462643002: Small clean up of externalizing strings. (Closed)

Created:
6 years, 4 months ago by Yang
Modified:
6 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Small clean up of externalizing strings. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23043

Patch Set 1 #

Patch Set 2 : change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M src/api.cc View 1 4 chunks +6 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 4 months ago (2014-08-11 12:22:23 UTC) #1
Toon Verwaest
lgtm
6 years, 4 months ago (2014-08-11 13:59:33 UTC) #2
Yang
6 years, 4 months ago (2014-08-11 14:04:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 23043 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698