src/factory.cc - Issue 462643002: Small clean up of externalizing strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 462643002: Small clean up of externalizing strings. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: change Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index a52b95719db05276362f7325ec32be751b37d87a..0d885fc3dbc851d8ce194e4ae8e6be62ce5b5076 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -270,6 +270,7 @@ MaybeHandle<String> Factory::NewStringFromTwoByte(Vector<const uc16> string,

int length = string.length();

const uc16* start = string.start();

if (String::IsOneByte(start, length)) {

+ if (length == 1) return LookupSingleCharacterStringFromCode(string[0]);

Handle<SeqOneByteString> result;

ASSIGN_RETURN_ON_EXCEPTION(

isolate(),

« no previous file with comments | « src/api.cc ('k') | src/objects.cc » ('j') | no next file with comments »