Issue 462613002: Cleanup namespace usage in Source/web/[A-V]*.h

Issue 462613002: Cleanup namespace usage in Source/web/[A-V]*.h (Closed)

Created:
6 years, 4 months ago by deepak.sa

Modified:
6 years, 4 months ago

Reviewers:
tkent, keishi

CC:
blink-reviews, nhiroki, mvanouwerkerk+watch_chromium.org, kinuko+fileapi, timvolodine, tzik

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Cleanup namespace usage in Source/web/[A-V]*.h This patch removes unnecessary blink:: prefixes. Also it merges *namspace blink{}* blocks. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179959

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Addressing comments #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+302 lines, -341 lines)			Patch
M	Source/web/AssociatedURLLoader.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/web/ChromeClientImpl.h	View		5 chunks	+52 lines, -55 lines	0 comments	Download
M	Source/web/DateTimeChooserImpl.h	View	1 2	1 chunk	+13 lines, -16 lines	0 comments	Download
M	Source/web/ExternalPopupMenu.h	View		3 chunks	+10 lines, -13 lines	0 comments	Download
M	Source/web/FrameLoaderClientImpl.h	View		4 chunks	+52 lines, -52 lines	0 comments	Download
M	Source/web/FullscreenController.h	View	1 2	3 chunks	+8 lines, -10 lines	0 comments	Download
M	Source/web/GeolocationClientProxy.h	View		1 chunk	+7 lines, -9 lines	0 comments	Download
M	Source/web/GraphicsLayerFactoryChromium.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/web/InspectorClientImpl.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/web/InspectorFrontendClientImpl.h	View		2 chunks	+5 lines, -8 lines	0 comments	Download
M	Source/web/LinkHighlight.h	View	1	2 chunks	+13 lines, -16 lines	0 comments	Download
M	Source/web/LocalFileSystemClient.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/web/PageOverlay.h	View	1 2	3 chunks	+5 lines, -7 lines	0 comments	Download
M	Source/web/PopupContainer.h	View		5 chunks	+25 lines, -27 lines	0 comments	Download
M	Source/web/PopupListBox.h	View		8 chunks	+24 lines, -27 lines	0 comments	Download
M	Source/web/PopupMenuChromium.h	View	1 2	1 chunk	+7 lines, -10 lines	0 comments	Download
M	Source/web/ScrollbarGroup.h	View		1 chunk	+27 lines, -30 lines	0 comments	Download
M	Source/web/ServiceWorkerGlobalScopeClientImpl.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/web/SharedWorkerRepositoryClientImpl.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/web/SpellCheckerClientImpl.h	View		2 chunks	+6 lines, -8 lines	0 comments	Download
M	Source/web/StorageClientImpl.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/web/StorageQuotaClientImpl.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/web/TextFinder.h	View		8 chunks	+12 lines, -14 lines	0 comments	Download
M	Source/web/ViewportAnchor.h	View		2 chunks	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/462613002/diff/20001/Source/web/DateTimeChooserImpl.h File Source/web/DateTimeChooserImpl.h (right): https://codereview.chromium.org/462613002/diff/20001/Source/web/DateTimeChooserImpl.h#newcode42 Source/web/DateTimeChooserImpl.h:42: class ChromeClientImpl; Please sort alphabetically. https://codereview.chromium.org/462613002/diff/20001/Source/web/PageOverlay.h File Source/web/PageOverlay.h (right): ...

6 years, 4 months ago (2014-08-11 13:23:18 UTC) #2

deepak.sa

6 years, 4 months ago (2014-08-11 13:39:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/462613002/40001

6 years, 4 months ago (2014-08-11 13:45:44 UTC) #5

Message was sent while issue was closed.

Change committed as 179959

Expand Messages | Collapse Messages