Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 462453002: Sheriff-O-Matic: Transition more unit tests to mocha. (Closed)

Created:
6 years, 4 months ago by michaelpg
Modified:
6 years, 4 months ago
Reviewers:
esprehn, ojan
CC:
abarth-chromium, blink-reviews, Dirk Pranke, dsinclair, dstockwell, leviw_travelin_and_unemployed, szager1
Project:
blink
Visibility:
Public.

Description

Sheriff-O-Matic: Transition more unit tests to mocha. I've switched from using requestAnimationFrame to setTimeout because: 1. requestAnimationFrame will cause timeouts if the tab is in the background while the tests are running 2. setTimeout is less verbose, since we can just pass the function name itself (requestAnimationFrame calls the function with a parameter, which would break the "done" function, so we have to wrap it in an anonymous function) BUG=400387 R=ojan@chromium.org,esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179988

Patch Set 1 : #

Patch Set 2 : rebase and fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -485 lines) Patch
M Tools/GardeningServer/karma.conf.js View 1 1 chunk +6 lines, -2 lines 0 comments Download
M Tools/GardeningServer/test/run-unit-tests.html View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/GardeningServer/test/unit-tests.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
D Tools/GardeningServer/ui/ct-builder-grid-tests.html View 1 chunk +0 lines, -88 lines 0 comments Download
D Tools/GardeningServer/ui/ct-builder-tests.html View 1 chunk +0 lines, -39 lines 0 comments Download
D Tools/GardeningServer/ui/ct-commit-list-tests.html View 1 chunk +0 lines, -64 lines 0 comments Download
D Tools/GardeningServer/ui/ct-commit-tests.html View 1 chunk +0 lines, -33 lines 0 comments Download
D Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html View 1 chunk +0 lines, -60 lines 0 comments Download
D Tools/GardeningServer/ui/ct-failure-analyzer-tests.html View 1 chunk +0 lines, -69 lines 0 comments Download
M Tools/GardeningServer/ui/test/ct-builder-grid-tests.html View 4 chunks +26 lines, -20 lines 0 comments Download
M Tools/GardeningServer/ui/test/ct-builder-tests.html View 1 chunk +9 lines, -17 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-commit-list-tests.html View 1 chunk +36 lines, -37 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-commit-tests.html View 1 chunk +17 lines, -12 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-embedded-flakiness-dashboard-tests.html View 1 1 chunk +52 lines, -42 lines 0 comments Download
A Tools/GardeningServer/ui/test/ct-failure-analyzer-tests.html View 1 chunk +73 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/test/ct-last-updated-tests.html View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
michaelpg
6 years, 4 months ago (2014-08-11 00:45:54 UTC) #1
ojan
lgtm esprehn, do you see any problem with using setTimeout instead of requestAnimationFrame?
6 years, 4 months ago (2014-08-11 01:48:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/462453002/60001
6 years, 4 months ago (2014-08-11 01:50:16 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 01:51:46 UTC) #4
commit-bot: I haz the power
Failed to apply patch for Tools/GardeningServer/test/unit-tests.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-08-11 01:51:57 UTC) #5
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 4 months ago (2014-08-11 18:33:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/462453002/80001
6 years, 4 months ago (2014-08-11 18:33:36 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 19:31:17 UTC) #8
Message was sent while issue was closed.
Change committed as 179988

Powered by Google App Engine
This is Rietveld 408576698