Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Unified Diff: Tools/GardeningServer/ui/test/ct-builder-tests.html

Issue 462453002: Sheriff-O-Matic: Transition more unit tests to mocha. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase and fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/test/ct-builder-tests.html
diff --git a/Tools/GardeningServer/ui/test/ct-builder-tests.html b/Tools/GardeningServer/ui/test/ct-builder-tests.html
index 6b1d4b76ad691e12d00c0a84303a8b58ff92330f..0cff862b1ca0517e7aacda019764e7d65d27e36f 100644
--- a/Tools/GardeningServer/ui/test/ct-builder-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-builder-tests.html
@@ -13,32 +13,24 @@ var assert = chai.assert;
describe('ct-builder', function() {
var builder;
+ var masterUrl = 'http://url';
+ var builderName = 'WebKit Linux (dbg)';
+ var firstFailingBuild = '1234';
beforeEach(function(done) {
builder = document.createElement('ct-builder');
- builder.builder = 'WebKit Linux (dbg)';
- requestAnimationFrame(function() { done(); });
+ builder.builder = new CTBuilder(masterUrl, builderName, firstFailingBuild);
+
+ setTimeout(done);
});
describe('default builder UI', function() {
it('should link to the builder', function() {
var a = builder.shadowRoot.querySelector('a');
- assert.ok(a.href);
- assert.include(a.href, 'WebKit+Linux+(dbg)');
- });
- });
-
- describe('builder UI with steps', function() {
- beforeEach(function(done) {
- builder.steps = ['gclient_revert', 'compile', 'unittests'];
- requestAnimationFrame(function() { done(); });
- });
-
- it('should link to builder and show steps', function() {
- var a = builder.shadowRoot.querySelector('a');
assert.ok(a);
- assert.include(a.href, 'WebKit+Linux+(dbg)');
- assert.include(a.innerText, 'gclient_revert, compile, unittests');
+ assert(a.href.startsWith(masterUrl));
+ assert.include(a.href, encodeURIComponent(builderName));
+ assert.include(a.href, firstFailingBuild);
});
});
});
« no previous file with comments | « Tools/GardeningServer/ui/test/ct-builder-grid-tests.html ('k') | Tools/GardeningServer/ui/test/ct-commit-list-tests.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698