Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 462353003: Cleanup namespace usage in Source/web[A-V]*.cpp (Closed)

Created:
6 years, 4 months ago by deepak.sa
Modified:
6 years, 4 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews, feature-media-reviews_chromium.org, gavinp+prerender_chromium.org, tzik, eric.carlson_apple.com, philipj_slow, timvolodine, nhiroki, mvanouwerkerk+watch_chromium.org, groby+blinkspell_chromium.org, dcheng, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage in Source/web[A-V]*.cpp This patch removes unnecessary blink:: prefixes. It removes unnecesssary *using* keyword lines. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180234

Patch Set 1 #

Patch Set 2 : Minor updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -194 lines) Patch
M Source/web/AssociatedURLLoader.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M Source/web/BackForwardClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 7 chunks +9 lines, -11 lines 0 comments Download
M Source/web/ColorChooserPopupUIController.cpp View 4 chunks +6 lines, -8 lines 0 comments Download
M Source/web/ColorChooserUIController.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/CompositionUnderlineVectorBuilder.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ContextFeaturesClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/web/DatabaseClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 4 chunks +26 lines, -28 lines 0 comments Download
M Source/web/DragClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 3 chunks +3 lines, -5 lines 0 comments Download
M Source/web/ExternalDateTimeChooser.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M Source/web/ExternalPopupMenu.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M Source/web/FindInPageCoordinates.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 6 chunks +6 lines, -8 lines 0 comments Download
M Source/web/FullscreenController.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M Source/web/GeolocationClientProxy.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/web/GraphicsLayerFactoryChromium.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/IndexedDBClientImpl.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/web/InspectorClientImpl.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/InspectorFrontendClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/LinkHighlight.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/LocalFileSystemClient.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/MIDIClientProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/MediaKeysClientImpl.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/NavigatorContentUtilsClientImpl.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/web/PageOverlay.cpp View 4 chunks +3 lines, -5 lines 0 comments Download
M Source/web/PageOverlayList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/PageScaleConstraintsSet.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/PopupContainer.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/PopupListBox.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/PopupMenuChromium.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/PrerendererClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/RemoteFrameClient.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/web/ScrollbarGroup.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/SpeechRecognitionClientProxy.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/SpellCheckerClientImpl.cpp View 1 3 chunks +2 lines, -4 lines 0 comments Download
M Source/web/StorageClientImpl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/web/StorageQuotaClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/TextFinder.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/UserMediaClientImpl.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ValidationMessageClientImpl.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M Source/web/ViewportAnchor.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
deepak.sa
PTAL? Thanks!
6 years, 4 months ago (2014-08-13 07:15:02 UTC) #1
keishi
LGTM, but I'm not an owner and tkent is ooo today.
6 years, 4 months ago (2014-08-13 07:34:09 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-14 00:45:52 UTC) #3
tkent
lgtm
6 years, 4 months ago (2014-08-14 00:45:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/462353003/20001
6 years, 4 months ago (2014-08-14 00:46:27 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-14 05:07:04 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180234

Powered by Google App Engine
This is Rietveld 408576698