Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 462283002: Fix crasher in the pdf tear down code path. (Closed)

Created:
6 years, 4 months ago by ananta
Modified:
6 years, 4 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Fix crasher in the pdf tear down code path. The crash occurs because of a timer dereferencing a null engine pointer. The crash appears to have occurred due to this patch https://codereview.chromium.org/427583003/ Fix is to cancel all timers when the pdf instance is being torn down before destroying the engine. BUG=403036 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pdf/instance.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
ananta
6 years, 4 months ago (2014-08-12 23:16:33 UTC) #1
Tom Sepez
LGTM. Thanks for catching this.
6 years, 4 months ago (2014-08-12 23:28:09 UTC) #2
ananta
+jam for pdf owners stamp
6 years, 4 months ago (2014-08-12 23:31:08 UTC) #3
jam
lgtm
6 years, 4 months ago (2014-08-13 00:09:15 UTC) #4
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 4 months ago (2014-08-13 00:10:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/462283002/1
6 years, 4 months ago (2014-08-13 00:18:29 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-13 01:28:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 01:42:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel/builds/6208)
6 years, 4 months ago (2014-08-13 01:42:31 UTC) #9
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 4 months ago (2014-08-13 01:44:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/462283002/1
6 years, 4 months ago (2014-08-13 01:49:32 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 08:52:10 UTC) #12
Message was sent while issue was closed.
Change committed as 289218

Powered by Google App Engine
This is Rietveld 408576698