Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: pdf/instance.cc

Issue 462283002: Fix crasher in the pdf tear down code path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/instance.cc
diff --git a/pdf/instance.cc b/pdf/instance.cc
index d779089f0067f5d23829eede408644640bcabbda..9cb78294b090980824760b2b3a51dddeb026c48e 100644
--- a/pdf/instance.cc
+++ b/pdf/instance.cc
@@ -307,6 +307,10 @@ Instance::Instance(PP_Instance instance)
}
Instance::~Instance() {
+ if (timer_pending_) {
+ timer_factory_.CancelAll();
+ timer_pending_ = false;
+ }
// The engine may try to access this instance during its destruction.
// Make sure this happens early while the instance is still intact.
engine_.reset();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698