Chromium Code Reviews Chromium Code Reviews
Issue 462243002:
Make logical height calculations on RenderView use unscaled FrameRect (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: LayoutTests/plugins/page-scale-does-not-affect-plugin-height.html |
| diff --git a/LayoutTests/plugins/page-scale-does-not-affect-plugin-height.html b/LayoutTests/plugins/page-scale-does-not-affect-plugin-height.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..26b3fe4a0ad3dab999b79a22bb86f9e5c50f5647 |
| --- /dev/null |
| +++ b/LayoutTests/plugins/page-scale-does-not-affect-plugin-height.html |
| @@ -0,0 +1,17 @@ |
| +<title> |
|
Julien - ping for review
2014/08/16 00:54:16
DOCTYPE PLEASE!!
bokan
2014/08/18 14:27:33
Done.
|
| + This test checks that page scale does not affect a plugin object's height when it depends on the window height |
|
Julien - ping for review
2014/08/16 00:54:16
Let's include an expected result (dumped into the
bokan
2014/08/18 14:27:33
Done.
|
| +</title> |
|
Julien - ping for review
2014/08/16 00:54:16
I don't like using title as it doesn't dump into t
bokan
2014/08/18 14:27:32
Done.
|
| +<script> |
| + function runTest() { |
| + if (window.testRunner) |
| + testRunner.dumpAsText(); |
| + |
| + if (window.eventSender) |
| + window.eventSender.setPageScaleFactor(1.5, 0, 0); |
| + |
| + document.body.innerHTML = internals.elementRenderTreeAsText(document.getElementById('box')); |
|
Julien - ping for review
2014/08/16 00:54:17
I would keep the description about in the output.
bokan
2014/08/18 14:27:33
Done.
|
| + } |
| +</script> |
| +<body marginwidth="0" marginheight="0" onload="runTest()"> |
|
Julien - ping for review
2014/08/16 00:54:16
I just learned about these 2 attributes.
Nit: I w
bokan
2014/08/18 14:27:33
Done.
|
| + <embed id="box" width="100%" height="100%" name="plugin" src="fileDoesNotExist.pdf" type="application/pdf"></embed> |
| +</body> |
