LayoutTests/plugins/page-scale-does-not-affect-plugin-height.html - Issue 462243002: Make logical height calculations on RenderView use unscaled FrameRect

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/plugins/page-scale-does-not-affect-plugin-height.html

Issue 462243002: Make logical height calculations on RenderView use unscaled FrameRect (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <title>
	Julien - ping for review 2014/08/16 00:54:16 DOCTYPE PLEASE!! DOCTYPE PLEASE!! bokan 2014/08/18 14:27:33 Done. Show quoted text On 2014/08/16 00:54:16, Julien Chaffraix - PST wrote: > DOCTYPE PLEASE!! Done.
	2 This test checks that page scale does not affect a plugin object's height wh en it depends on the window height
	Julien - ping for review 2014/08/16 00:54:16 Let's include an expected result (dumped into the Let's include an expected result (dumped into the output). Also it's good to include instructions for people testing manually (like a gardener trying to understand what's going on with this test). bokan 2014/08/18 14:27:33 Done. Show quoted text On 2014/08/16 00:54:16, Julien Chaffraix - PST wrote: > Let's include an expected result (dumped into the output). > > Also it's good to include instructions for people testing manually (like a > gardener trying to understand what's going on with this test). Done.
	3 </title>
	Julien - ping for review 2014/08/16 00:54:16 I don't like using title as it doesn't dump into t I don't like using title as it doesn't dump into the output (and is not shown in DRT at all): the information is important enough to put it, it should be dumped into the output. bokan 2014/08/18 14:27:32 Done. Show quoted text On 2014/08/16 00:54:16, Julien Chaffraix - PST wrote: > I don't like using title as it doesn't dump into the output (and is not shown in > DRT at all): the information is important enough to put it, it should be dumped > into the output. Done.
	4 <script>

	5 function runTest() {

	6 if (window.testRunner)

	7 testRunner.dumpAsText();

	8

	9 if (window.eventSender)

	10 window.eventSender.setPageScaleFactor(1.5, 0, 0);

	11

	12 document.body.innerHTML = internals.elementRenderTreeAsText(document.getElem entById('box'));
	Julien - ping for review 2014/08/16 00:54:17 I would keep the description about in the output. I would keep the description about in the output. bokan 2014/08/18 14:27:33 Done. Show quoted text On 2014/08/16 00:54:17, Julien Chaffraix - PST wrote: > I would keep the description about in the output. Done.
	13 }

	14 </script>

	15 <body marginwidth="0" marginheight="0" onload="runTest()">
	Julien - ping for review 2014/08/16 00:54:16 I just learned about these 2 attributes. Nit: I w I just learned about these 2 attributes. Nit: I would prefer some correct CSS instead of relying on some obscure ancillary attribute (wouldn't surprise me if they would be put to the deprecation roster one of these days). bokan 2014/08/18 14:27:33 Done. Show quoted text On 2014/08/16 00:54:16, Julien Chaffraix - PST wrote: > I just learned about these 2 attributes. > > Nit: I would prefer some correct CSS instead of relying on some obscure > ancillary attribute (wouldn't surprise me if they would be put to the > deprecation roster one of these days). Done.
	16 <embed id="box" width="100%" height="100%" name="plugin" src="fileDoesNotExist .pdf" type="application/pdf"></embed>

	17 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/plugins/page-scale-does-not-affect-plugin-height-expected.txt » ('j') | no next file with comments »