Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 462073003: Handle empty title attribute tooltips. (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Handle empty title attribute tooltips. The spec tells us that if an element has a title attribute, its value should be returned as its tooltip/advisory information: http://www.whatwg.org/specs/web-apps/current-work/#the-title-attribute Align with how other browsers behave for <foo title> and return the empty string rather than consult the parent element. R= BUG=399255 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180109

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
A + LayoutTests/fast/html/a-tooltip-null.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + LayoutTests/fast/html/a-tooltip-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/HitTestResult.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-12 15:25:36 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-12 17:36:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/462073003/1
6 years, 4 months ago (2014-08-12 17:37:23 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-12 19:12:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-12 19:40:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22347)
6 years, 4 months ago (2014-08-12 19:40:13 UTC) #6
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-12 21:24:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/462073003/1
6 years, 4 months ago (2014-08-12 21:26:35 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 22:35:34 UTC) #9
Message was sent while issue was closed.
Change committed as 180109

Powered by Google App Engine
This is Rietveld 408576698