Source/core/rendering/HitTestResult.cpp - Issue 462073003: Handle empty title attribute tooltips.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/HitTestResult.cpp

Issue 462073003: Handle empty title attribute tooltips. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/HitTestResult.cpp

diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp

index 96fdf8f42f756621a563d7b7eb751cdb6f7158c8..36bc85f2ed5a9765b071def3aa0e00e9c89b8cf3 100644

--- a/Source/core/rendering/HitTestResult.cpp

+++ b/Source/core/rendering/HitTestResult.cpp

@@ -232,7 +232,7 @@ String HitTestResult::title(TextDirection& dir) const

for (Node* titleNode = m_innerNode.get(); titleNode; titleNode = titleNode->parentNode()) {

if (titleNode->isElementNode()) {

String title = toElement(titleNode)->title();

- if (!title.isEmpty()) {

+ if (!title.isNull()) {

if (RenderObject* renderer = titleNode->renderer())

dir = renderer->style()->direction();

return title;

« no previous file with comments | « LayoutTests/fast/html/a-tooltip-null-expected.txt ('k') | no next file » | no next file with comments »