Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 462033002: Fix newly discovered presubmit errors. (Closed)

Created:
6 years, 4 months ago by Michael Starzinger
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix newly discovered presubmit errors. R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23081

Patch Set 1 #

Patch Set 2 : Fix implicit one-argument constructor calls. #

Patch Set 3 : More of the same. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -124 lines) Patch
M src/api.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/instrument-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +8 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter-irregexp.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/libplatform/worker-thread.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/log.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M src/macro-assembler.h View 1 chunk +10 lines, -10 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/optimizing-compiler-thread.h View 1 1 chunk +14 lines, -14 lines 0 comments Download
M src/splay-tree.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M test/base-unittests/platform/condition-variable-unittest.cc View 1 3 chunks +17 lines, -12 lines 0 comments Download
M test/base-unittests/platform/platform-unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 8 chunks +13 lines, -11 lines 0 comments Download
M test/cctest/test-circular-queue.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 5 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-libplatform.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-lockers.cc View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/test-semaphore.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-threads.cc View 1 2 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
6 years, 4 months ago (2014-08-12 13:11:15 UTC) #1
jochen (gone - plz use gerrit)
rubberstamp lgtm whatever makes the script happy
6 years, 4 months ago (2014-08-12 13:29:58 UTC) #2
Michael Starzinger
Committed patchset #3 manually as 23081 (presubmit successful).
6 years, 4 months ago (2014-08-12 13:34:07 UTC) #3
titzer
6 years, 4 months ago (2014-08-12 13:34:13 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698