Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 461833002: Clear breadcrumbs just before the new one is created. (Closed)

Created:
6 years, 4 months ago by fukino
Modified:
6 years, 4 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Clear breadcrumbs just before the new one is created. BUG=402196 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288934

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move attribute change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
fukino
@hirono - PTAL the CL? Thanks!
6 years, 4 months ago (2014-08-12 02:58:43 UTC) #1
hirono
https://codereview.chromium.org/461833002/diff/1/ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js File ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js (right): https://codereview.chromium.org/461833002/diff/1/ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js#newcode46 ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js:46: this.bc_.hidden = false; Could you also move the attribute ...
6 years, 4 months ago (2014-08-12 03:12:38 UTC) #2
fukino
https://codereview.chromium.org/461833002/diff/1/ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js File ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js (right): https://codereview.chromium.org/461833002/diff/1/ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js#newcode46 ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js:46: this.bc_.hidden = false; On 2014/08/12 03:12:38, hirono wrote: > ...
6 years, 4 months ago (2014-08-12 03:24:11 UTC) #3
hirono
lgtm!
6 years, 4 months ago (2014-08-12 03:33:49 UTC) #4
fukino
On 2014/08/12 03:33:49, hirono wrote: > lgtm! Thanks!
6 years, 4 months ago (2014-08-12 03:34:10 UTC) #5
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 4 months ago (2014-08-12 03:34:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/461833002/20001
6 years, 4 months ago (2014-08-12 03:34:44 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-12 04:39:54 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 11:46:27 UTC) #9
Message was sent while issue was closed. 
Change committed as 288934

Powered by Google App Engine
This is Rietveld 408576698