Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js

Issue 461833002: Clear breadcrumbs just before the new one is created. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move attribute change. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js b/ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js
index 7f78047412d75864f200579c564c8272e11a934f..1e8c601c688a374513233f61b4a70c6772bc8269 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/breadcrumbs_controller.js
@@ -43,8 +43,6 @@ BreadcrumbsController.prototype.show = function(entry) {
return;
this.entry_ = entry;
- this.bc_.hidden = false;
- this.bc_.textContent = '';
this.showSequence_++;
var queue = new AsyncUtil.Queue();
@@ -117,8 +115,12 @@ BreadcrumbsController.prototype.show = function(entry) {
// Update DOM element.
queue.run(function(sequence, callback) {
// Check the sequence number to skip requests that are out of date.
- if (this.showSequence_ === sequence && !error)
- this.updateInternal_(entries);
+ if (this.showSequence_ === sequence) {
+ this.bc_.hidden = false;
+ this.bc_.textContent = '';
+ if (!error)
+ this.updateInternal_(entries);
+ }
callback();
}.bind(this, this.showSequence_));
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698