Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 461643002: add localMatrix to gradient Descriptor (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add localMatrix to gradient Descriptor this consolidation will also help transisition to new flattening pattern, where we want to have a flatten/unflatten method on all of the common gradient params (i.e. Descriptor). BUG=skia: Committed: https://skia.googlesource.com/skia/+/addf2edf3da20f053daa3897cfe2c52d7369a7b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -56 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 8 chunks +18 lines, -18 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.h View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
6 years, 4 months ago (2014-08-11 15:04:04 UTC) #1
reed1
The CQ bit was checked by reed@google.com
6 years, 4 months ago (2014-08-11 15:04:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/461643002/1
6 years, 4 months ago (2014-08-11 15:04:36 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-11 15:04:37 UTC) #4
egdaniel
lgtm
6 years, 4 months ago (2014-08-11 15:26:55 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 15:28:29 UTC) #6
Message was sent while issue was closed. 
Change committed as addf2edf3da20f053daa3897cfe2c52d7369a7b1

Powered by Google App Engine
This is Rietveld 408576698