components/translate/content/renderer/translate_helper.h - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/renderer/translate_helper.h

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge error in chrome/browser/BUILD.gn Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/translate/content/renderer/renderer_cld_data_provider.cc ('K') | « components/translate/content/renderer/static_renderer_cld_data_provider.cc ('k') | components/translate/content/renderer/translate_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/renderer/translate_helper.h

diff --git a/components/translate/content/renderer/translate_helper.h b/components/translate/content/renderer/translate_helper.h

index 6e12c69dede4f3b52f4d32c1825614502bd37a66..39b63a1cdce5ca4fb05639705793b04927e10811 100644

--- a/components/translate/content/renderer/translate_helper.h

+++ b/components/translate/content/renderer/translate_helper.h

@@ -244,7 +244,10 @@ class TranslateHelper : public content::RenderViewObserver {

base::TimeTicks language_determined_time_;

// Provides CLD data for this process.

- scoped_ptr<RendererCldDataProvider> cld_data_provider_;

+ // The pointer is owned by the global in RendererCldDataProvider and has the

+ // same lifetime as the process itself, so this field is simply a raw pointer

+ // instead of a scoped_ptr.

+ RendererCldDataProvider* cld_data_provider_;

// Whether or not polling for CLD2 data has started.

bool cld_data_polling_started_;