components/translate/content/renderer/static_renderer_cld_data_provider.cc - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/renderer/static_renderer_cld_data_provider.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge error in chrome/browser/BUILD.gn Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/translate/content/renderer/renderer_cld_data_provider.cc ('K') | « components/translate/content/renderer/renderer_cld_data_provider.cc ('k') | components/translate/content/renderer/translate_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/renderer/static_renderer_cld_data_provider.cc

diff --git a/components/translate/content/renderer/static_renderer_cld_data_provider.cc b/components/translate/content/renderer/static_renderer_cld_data_provider.cc

index bb2ccf1cc8d8ce4e930e5892dc9101396d095ae1..b76e1b02c666fc015679287f7b765c9ea363d0af 100644

--- a/components/translate/content/renderer/static_renderer_cld_data_provider.cc

+++ b/components/translate/content/renderer/static_renderer_cld_data_provider.cc

@@ -4,16 +4,9 @@

#include "static_renderer_cld_data_provider.h"

-#include "content/public/renderer/render_view_observer.h"

#include "ipc/ipc_message.h"

namespace translate {

-// Implementation of the static factory method from RendererCldDataProvider,

-// hooking up this specific implementation for all of Chromium.

-RendererCldDataProvider* CreateRendererCldDataProviderFor(

- content::RenderViewObserver* render_view_observer) {

- return new StaticRendererCldDataProvider();

StaticRendererCldDataProvider::StaticRendererCldDataProvider() {

}