Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: components/translate/content/browser/static_browser_cld_data_provider.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix merge error in chrome/browser/BUILD.gn Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/content/browser/static_browser_cld_data_provider.cc
diff --git a/components/translate/content/browser/static_browser_cld_data_provider.cc b/components/translate/content/browser/static_browser_cld_data_provider.cc
index 675db42d08e3c26af8792622c17ea6129df2be67..fda357dd00cf2f18f67b9259b4ef49ea206a84a6 100644
--- a/components/translate/content/browser/static_browser_cld_data_provider.cc
+++ b/components/translate/content/browser/static_browser_cld_data_provider.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "static_browser_cld_data_provider.h"
+#include "components/translate/content/browser/static_browser_cld_data_provider.h"
#include "base/logging.h"
#include "content/public/browser/web_contents.h"
@@ -10,25 +10,6 @@
namespace translate {
-// Implementation of the static factory method from BrowserCldDataProvider,
-// hooking up this specific implementation for all of Chromium.
-BrowserCldDataProvider* CreateBrowserCldDataProviderFor(
- content::WebContents* web_contents) {
- // This log line is to help with determining which kind of provider has been
- // configured. See also: chrome://translate-internals
- VLOG(1) << "Creating StaticBrowserCldDataProvider";
- return new StaticBrowserCldDataProvider();
-}
-
-void SetCldDataFilePath(const base::FilePath& path) {
- LOG(WARNING) << "Not supported: SetCldDataFilePath";
- return;
-}
-
-base::FilePath GetCldDataFilePath() {
- return base::FilePath(); // empty path
-}
-
void ConfigureBrowserCldDataProvider(const void* config) {
// No-op: data is statically linked
}

Powered by Google App Engine
This is Rietveld 408576698