components/translate/content/browser/data_file_browser_cld_data_provider.h - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/data_file_browser_cld_data_provider.h

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix merge error in chrome/browser/BUILD.gn Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/translate/content/browser/browser_cld_utils.cc ('K') | « components/translate/content/browser/browser_cld_utils.cc ('k') | components/translate/content/browser/data_file_browser_cld_data_provider.cc » ('j') | components/translate/content/browser/static_browser_cld_data_provider_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/browser/data_file_browser_cld_data_provider.h

diff --git a/components/translate/content/browser/data_file_browser_cld_data_provider.h b/components/translate/content/browser/data_file_browser_cld_data_provider.h

index 7b4f17e96746e6bca5fdfa1986baa1ecdd41be89..90ab232608b1781347a8748af772fa848c2dff6c 100644

--- a/components/translate/content/browser/data_file_browser_cld_data_provider.h

+++ b/components/translate/content/browser/data_file_browser_cld_data_provider.h

@@ -12,6 +12,10 @@

#include "base/memory/weak_ptr.h"

#include "components/translate/content/browser/browser_cld_data_provider.h"

+namespace content {

+class WebContents;

+} // namespace content

jochen (gone - plz use gerrit) 2014/10/23 13:57:39 // namespace content not required for forward decl

Andrew Hayden (chromium.org) 2014/10/30 16:56:32 Acknowledged.

namespace translate {

class DataFileBrowserCldDataProvider : public BrowserCldDataProvider {