Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: components/translate/content/browser/static_browser_cld_data_provider_factory.h

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/content/browser/static_browser_cld_data_provider_factory.h
diff --git a/components/translate/content/browser/static_browser_cld_data_provider.h b/components/translate/content/browser/static_browser_cld_data_provider_factory.h
similarity index 51%
copy from components/translate/content/browser/static_browser_cld_data_provider.h
copy to components/translate/content/browser/static_browser_cld_data_provider_factory.h
index fe2ab0e4616220056453173ba48486f85ac4bb4c..dfc42294bd932e4c66cfcbb01170cabfe91ff921 100644
--- a/components/translate/content/browser/static_browser_cld_data_provider.h
+++ b/components/translate/content/browser/static_browser_cld_data_provider_factory.h
@@ -2,27 +2,27 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_TRANSLATE_CONTENT_BROWSER_STATIC_BROWSER_CLD_DATA_PROVIDER_H_
-#define COMPONENTS_TRANSLATE_CONTENT_BROWSER_STATIC_BROWSER_CLD_DATA_PROVIDER_H_
+#ifndef COMPONENTS_TRANSLATE_CONTENT_BROWSER_STATIC_BROWSER_CLD_DATA_PROVIDER_FACTORY_H_
+#define COMPONENTS_TRANSLATE_CONTENT_BROWSER_STATIC_BROWSER_CLD_DATA_PROVIDER_FACTORY_H_
#include "base/macros.h"
-#include "components/translate/content/browser/browser_cld_data_provider.h"
+#include "components/translate/content/browser/browser_cld_data_provider_factory.h"
namespace translate {
-class StaticBrowserCldDataProvider : public BrowserCldDataProvider {
+class StaticBrowserCldDataProviderFactory :
+ public BrowserCldDataProviderFactory {
public:
- explicit StaticBrowserCldDataProvider();
- virtual ~StaticBrowserCldDataProvider();
- // BrowserCldDataProvider implementations:
- virtual bool OnMessageReceived(const IPC::Message&) OVERRIDE;
- virtual void OnCldDataRequest() OVERRIDE;
- virtual void SendCldDataResponse() OVERRIDE;
+ explicit StaticBrowserCldDataProviderFactory();
+ virtual ~StaticBrowserCldDataProviderFactory();
+ // BrowserCldDataProviderFactory implementations:
+ virtual BrowserCldDataProvider* NewProvider(
+ content::WebContents* web_contents) OVERRIDE;
private:
- DISALLOW_COPY_AND_ASSIGN(StaticBrowserCldDataProvider);
+ DISALLOW_COPY_AND_ASSIGN(StaticBrowserCldDataProviderFactory);
};
} // namespace translate
-#endif // COMPONENTS_TRANSLATE_CONTENT_BROWSER_STATIC_BROWSER_CLD_DATA_PROVIDER_H_
+#endif // COMPONENTS_TRANSLATE_CONTENT_BROWSER_STATIC_BROWSER_CLD_DATA_PROVIDER_FACTORY_H_

Powered by Google App Engine
This is Rietveld 408576698