Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: components/translate/content/browser/static_browser_cld_data_provider.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/content/browser/static_browser_cld_data_provider.cc
diff --git a/components/translate/content/browser/static_browser_cld_data_provider.cc b/components/translate/content/browser/static_browser_cld_data_provider.cc
index 675db42d08e3c26af8792622c17ea6129df2be67..959ee773431c635b5df08b3788ff6c13fc755a93 100644
--- a/components/translate/content/browser/static_browser_cld_data_provider.cc
+++ b/components/translate/content/browser/static_browser_cld_data_provider.cc
@@ -10,25 +10,6 @@
namespace translate {
-// Implementation of the static factory method from BrowserCldDataProvider,
-// hooking up this specific implementation for all of Chromium.
-BrowserCldDataProvider* CreateBrowserCldDataProviderFor(
- content::WebContents* web_contents) {
- // This log line is to help with determining which kind of provider has been
- // configured. See also: chrome://translate-internals
- VLOG(1) << "Creating StaticBrowserCldDataProvider";
- return new StaticBrowserCldDataProvider();
-}
-
-void SetCldDataFilePath(const base::FilePath& path) {
- LOG(WARNING) << "Not supported: SetCldDataFilePath";
- return;
-}
-
-base::FilePath GetCldDataFilePath() {
- return base::FilePath(); // empty path
-}
-
void ConfigureBrowserCldDataProvider(const void* config) {
// No-op: data is statically linked
}

Powered by Google App Engine
This is Rietveld 408576698