chrome/browser/policy/policy_browsertest.cc - Issue 461633002: Refactor language detection logic to allow non-static CLD data sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_browser_main.cc ('K') | « chrome/browser/component_updater/cld_component_installer.cc ('k') | chrome/browser/translate/chrome_translate_client.cc » ('j') | chrome/browser/translate/cld_data_harness.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/policy_browsertest.cc

diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc

index eff4c9944e0ad56eab245d21ab1b24024acd3966..a1c4f44ea0724d0bf0d09db3f771c37448b8f15d 100644

--- a/chrome/browser/policy/policy_browsertest.cc

+++ b/chrome/browser/policy/policy_browsertest.cc

@@ -58,6 +58,7 @@

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/browser/translate/chrome_translate_client.h"

#include "chrome/browser/translate/cld_data_harness.h"

+#include "chrome/browser/translate/cld_data_harness_factory.h"

#include "chrome/browser/translate/translate_service.h"

#include "chrome/browser/ui/bookmarks/bookmark_bar.h"

#include "chrome/browser/ui/browser.h"

@@ -2002,7 +2003,7 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DISABLED_TranslateEnabled) {

return;

scoped_ptr<test::CldDataHarness> cld_data_scope =

- test::CreateCldDataHarness();

+ test::CldDataHarnessFactory::Get()->CreateCldDataHarness();

ASSERT_NO_FATAL_FAILURE(cld_data_scope->Init());

// Verifies that translate can be forced enabled or disabled by policy.