Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3411)

Unified Diff: chrome/browser/translate/cld_data_harness.cc

Issue 461633002: Refactor language detection logic to allow non-static CLD data sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Create a factory for test harnesses and use it Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/cld_data_harness.cc
diff --git a/chrome/browser/translate/cld_data_harness.cc b/chrome/browser/translate/cld_data_harness.cc
index 9546d6f256fd55056bcbe95d072944fdab2f16b7..4259130fb1af59514598cc11c74cd54a253e6fb4 100644
--- a/chrome/browser/translate/cld_data_harness.cc
+++ b/chrome/browser/translate/cld_data_harness.cc
@@ -4,8 +4,12 @@
#include "chrome/browser/translate/cld_data_harness.h"
+#include "base/lazy_instance.h"
#include "base/path_service.h"
+#include "chrome/browser/translate/component_cld_data_harness.h"
+#include "chrome/browser/translate/standalone_cld_data_harness.h"
#include "chrome/common/chrome_paths.h"
+#include "components/translate/content/common/cld_data_source.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
@@ -15,6 +19,21 @@ namespace {
// chrome/test/data/cld2_component/README.chromium; don't update one without
// updating the other.
const base::FilePath::CharType kCrxVersion[] = FILE_PATH_LITERAL("160");
+
+class StaticCldDataHarness : public test::CldDataHarness {
+ public:
+ virtual void Init() OVERRIDE {
+ translate::CldDataSource::Set(translate::CldDataSource::STATIC(), true);
picksi1 2014/09/29 15:59:08 see comment about 'false' earlier!
Andrew Hayden (chromium.org) 2014/10/30 14:25:14 Fixed!
+ }
+};
+
+class NoneCldDataHarness : public test::CldDataHarness {
+ public:
+ virtual void Init() OVERRIDE {
+ translate::CldDataSource::Set(translate::CldDataSource::NONE(), true);
+ }
+};
+
} // namespace
namespace test {
@@ -29,4 +48,20 @@ void CldDataHarness::GetTestDataSourceDirectory(base::FilePath* out_path) {
out_path->Append(FILE_PATH_LITERAL("cld2_component")).Append(kCrxVersion);
}
+/* static */ scoped_ptr<CldDataHarness> CldDataHarness::NONE() {
+ return scoped_ptr<CldDataHarness>(new NoneCldDataHarness());
+}
+
+/* static */ scoped_ptr<CldDataHarness> CldDataHarness::STATIC() {
+ return scoped_ptr<CldDataHarness>(new StaticCldDataHarness());
+}
+
+/* static */ scoped_ptr<CldDataHarness> CldDataHarness::STANDALONE() {
+ return scoped_ptr<CldDataHarness>(new StandaloneCldDataHarness());
+}
+
+/* static */ scoped_ptr<CldDataHarness> CldDataHarness::COMPONENT() {
+ return scoped_ptr<CldDataHarness>(new ComponentCldDataHarness());
+}
+
} // namespace test

Powered by Google App Engine
This is Rietveld 408576698